Fix left offset calculation of RTL prev navigation #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, testing this out with https://github.com/IDPF/epub3-samples/releases/download/20170606/israelsailing.epub |
Contributor
|
Thanks again for the help with RTL navigation. What browser what this causing issue in? I didn't see any issues in that book with Chrome but this MR seems to work as well so will merge now and hopefully that will fix the issues! |
Contributor
Author
|
Thanks for the merge. Chrome and you will notice the issue with small screen width ex. Mobile and below |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed calculation issue when performing a prev navigation of RTL books.
The issue was skipping display of first page and jump into previous chapter
the scope of this issue/fix is within default manager