Fix spine node index in CFIs #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix is needed in two places. 1.) packaging.js -> use "children" to find only elements rather than "childNode" which can sometimes return text nodes and comment nodes, depending on the format of package.opf. 2.) epubcfi.js -> multiple the spine index by 2 to conform to CFI rules. NOTE: The existing code works due to these two bugs canceling each other out for cases when the package.opf is formatted with spacing and no comments (and hence including two nodes for every one element in the spine).
Contributor
|
This all looks good, thanks for tracking the issue down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix is needed in two places.
1.) packaging.js -> use "children" to find only elements rather than "childNode" which can sometimes return text nodes and comment nodes, depending on the format of package.opf.
2.) epubcfi.js -> multiple the spine index by 2 to conform to CFI rules.
NOTE: The existing code works due to these two bugs canceling each other out for cases when the package.opf is formatted with spacing and no comments (and hence including two nodes for every one element in the spine).