feat: add allowPopups option

azu · azu · commit c168bb91ce6e · 2022-02-05T14:52:55.000+09:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/managers/continuous/index.js b/src/managers/continuous/index.js
@@ -22,7 +22,8 @@ class ContinuousViewManager extends DefaultViewManager {
 			height: undefined,
 			snap: false,
 			afterScrolledTimeout: 10,
-			allowScriptedContent: false
+			allowScriptedContent: false,
+			allowPopups: false
 		});
 
 		extend(this.settings, options.settings || {});
@@ -40,7 +41,8 @@ class ContinuousViewManager extends DefaultViewManager {
 			width: 0,
 			height: 0,
 			forceEvenPages: false,
-			allowScriptedContent: this.settings.allowScriptedContent
+			allowScriptedContent: this.settings.allowScriptedContent,
+			allowPopups: this.settings.allowPopups
 		};
 
 		this.scrollTop = 0;
@@ -382,7 +384,7 @@ class ContinuousViewManager extends DefaultViewManager {
 			} else {
 				if(this.settings.direction === 'rtl') {
 					if (!this.settings.fullsize) {
-						this.scrollTo(prevLeft, 0, true);					
+						this.scrollTo(prevLeft, 0, true);
 					} else {
 						this.scrollTo(prevLeft + Math.floor(bounds.width), 0, true);
 					}
diff --git a/src/managers/default/index.js b/src/managers/default/index.js
@@ -27,7 +27,8 @@ class DefaultViewManager {
 			flow: "scrolled",
 			ignoreClass: "",
 			fullsize: undefined,
-			allowScriptedContent: false
+			allowScriptedContent: false,
+			allowPopups: false
 		});
 
 		extend(this.settings, options.settings || {});
@@ -41,7 +42,8 @@ class DefaultViewManager {
 			width: 0,
 			height: 0,
 			forceEvenPages: true,
-			allowScriptedContent: this.settings.allowScriptedContent
+			allowScriptedContent: this.settings.allowScriptedContent,
+			allowPopups: this.settings.allowPopups
 		};
 
 		this.rendered = false;
@@ -356,11 +358,11 @@ class DefaultViewManager {
 		}
 		if(this.settings.direction === 'rtl'){
 			/***
-				the `floor` function above (L343) is on positive values, so we should add one `layout.delta` 
+				the `floor` function above (L343) is on positive values, so we should add one `layout.delta`
 				to distX or use `Math.ceil` function, or multiply offset.left by -1
 				before `Math.floor`
 			*/
-			distX = distX + this.layout.delta 
+			distX = distX + this.layout.delta
 			distX = distX - width
 		}
 		this.scrollTo(distX, distY, true);
@@ -672,8 +674,8 @@ class DefaultViewManager {
 		let pageHeight = (container.height < window.innerHeight) ? container.height : window.innerHeight;
 		let pageWidth = (container.width < window.innerWidth) ? container.width : window.innerWidth;
 		let vertical = (this.settings.axis === "vertical");
-		let rtl =  (this.settings.direction === "rtl"); 
-			
+		let rtl =  (this.settings.direction === "rtl");
+		
 		let offset = 0;
 		let used = 0;
 
diff --git a/src/managers/views/iframe.js b/src/managers/views/iframe.js
@@ -17,7 +17,8 @@ class IframeView {
 			globalLayoutProperties: {},
 			method: undefined,
 			forceRight: false,
-			allowScriptedContent: false
+			allowScriptedContent: false,
+			allowPopups: false
 		}, options || {});
 
 		this.id = "epubjs-view-" + uuid();
@@ -92,9 +93,12 @@ class IframeView {
 		// sandbox
 		this.iframe.sandbox = "allow-same-origin";
 		if (this.settings.allowScriptedContent) {
-			this.iframe.sandbox += " allow-scripts"
+			this.iframe.sandbox += " allow-scripts";
 		}
-
+		if (this.settings.allowPopups) {
+			this.iframe.sandbox += " allow-popups";
+		}
+		
 		this.iframe.setAttribute("enable-annotation", "true");
 
 		this.resizing = true;
@@ -228,7 +232,7 @@ class IframeView {
 			this.lock("both", width, height);
 		} else if(this.settings.axis === "horizontal") {
 			this.lock("height", width, height);
-		} else {			
+		} else {
 			this.lock("width", width, height);
 		}
 
diff --git a/src/rendition.js b/src/rendition.js
@@ -38,6 +38,7 @@ import ContinuousViewManager from "./managers/continuous/index";
  * @param {boolean | object} [options.snap=false] use snap scrolling
  * @param {string} [options.defaultDirection='ltr'] default text direction
  * @param {boolean} [options.allowScriptedContent=false] enable running scripts in content
+ * @param {boolean} [options.allowPopups=false] enable opening popup in content
  */
 class Rendition {
 	constructor(book, options) {
@@ -57,7 +58,8 @@ class Rendition {
 			script: null,
 			snap: false,
 			defaultDirection: "ltr",
-			allowScriptedContent: false
+			allowScriptedContent: false,
+			allowPopups: false
 		});
 
 		extend(this.settings, options);
